Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS audit attributes for API Key authn #60033

Merged
merged 9 commits into from
Jul 23, 2020
Merged

DOCS audit attributes for API Key authn #60033

merged 9 commits into from
Jul 23, 2020

Conversation

albertzaharovits
Copy link
Contributor

This PR describes the new audit entry attributes api_key.id, api_key.name and authentication.type, as well as the meaning of existing attributes when authentication is performed using API keys.

This should've been part of #58928

@albertzaharovits albertzaharovits added >docs General docs changes :Security/Audit X-Pack Audit logging v8.0.0 v7.9.0 v7.10.0 labels Jul 22, 2020
@albertzaharovits albertzaharovits self-assigned this Jul 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Audit)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Security Meta label for security team labels Jul 22, 2020
jrodewig
jrodewig approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left some non-blocking suggestions. Feel free to take or ignore as you see fit. In general, they split the sentences and ensure that
API key is correctly capitalized.

x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/auditing/event-types.asciidoc Outdated Show resolved Hide resolved
albertzaharovits and others added 7 commits July 23, 2020 07:59
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
27d7e0e 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
2fd6a73 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
c25f146 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
66aeb49 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
6405af4 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
8f4b4c1 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits @jrodewig
Update x-pack/docs/en/security/auditing/event-types.asciidoc
ec5629d 
Co-authored-by: James Rodewig <[email protected]>
@albertzaharovits
Copy link
Contributor Author

Thank you @jrodewig ! It is much better phrased like this.

tvernum
tvernum approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits albertzaharovits merged commit 53c1d5e into elastic:master Jul 23, 2020
@albertzaharovits albertzaharovits deleted the docs_api_key_audit_fields branch July 23, 2020 12:49
albertzaharovits added a commit that referenced this pull request Jul 23, 2020
@albertzaharovits
DOCS audit attributes for API Key authn (#60033)
3ad3a7d 
This PR describes the new audit entry attributes api_key.id,
api_key.name and authentication.type, as well as the meaning of
existing attributes when authentication is performed using API keys.

This should've been part of #58928
albertzaharovits added a commit that referenced this pull request Jul 23, 2020
@albertzaharovits
[DOCS] audit attributes for API Key authn (#60033)
b7f2f5c 
This PR describes the new audit entry attributes api_key.id,
api_key.name and authentication.type, as well as the meaning of
existing attributes when authentication is performed using API keys.

This should've been part of #58928
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@tvernum tvernum tvernum approved these changes

Assignees

@albertzaharovits albertzaharovits

Labels
>docs General docs changes :Security/Audit X-Pack Audit logging Team:Docs Meta label for docs team Team:Security Meta label for security team v7.9.0 v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@albertzaharovits @elasticmachine @tvernum @jrodewig @jakelandis