Wrap up building parametrized TypeParsers #59977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
romseygeek
added a commit
that referenced
this pull request
Jul 21, 2020
The TypeParser implementations of all ParametrizedFieldMapper descendant classes are essentially the same - stateless, requiring the construction of a Builder object, and calling parse on it before returning it. We can make this easier (and less error-prone) to implement by wrapping the logic up into a final class, which takes a function to produce the Builder from a name and parser context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeParser implementations of all ParametrizedFieldMapper descendant classes are
essentially the same - stateless, requiring the construction of a
Builderobject, and callingparseon it before returning it. We can make this easier (and less error-prone) toimplement by wrapping the logic up into a final class, which takes a function to produce
the
Builderfrom a name and parser context.