Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused deprecate method in FormatNames #59949

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

pgomulka
Copy link
Contributor

The method was accidentally added in #59555
Deprecation is being done in DateFormatters and Joda classes in guard pattern style.

@pgomulka pgomulka added :Core/Infra/Core Core issues without another label v8.0.0 labels Jul 21, 2020
@pgomulka pgomulka self-assigned this Jul 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 21, 2020
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 2421679 into elastic:master Jul 21, 2020
pgomulka added a commit that referenced this pull request Feb 14, 2022
using camel case date formats was deprecated in
#59949
but only using deprecation logger.
This commit adds deprecation info checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants