Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API key name should always be required for creation #59836

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Jul 20, 2020

The name is now required when creating or granting API keys.

Resolves: #59484

@ywangd ywangd added >bug >breaking :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.10.0 labels Jul 20, 2020
@ywangd ywangd requested a review from tvernum July 20, 2020 04:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

@elasticmachine elasticmachine added the Team:Security Meta label for security team label Jul 20, 2020
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit 6ae04a5 into elastic:master Aug 4, 2020
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 4, 2020
The name is now required when creating or granting API keys.
ywangd added a commit that referenced this pull request Aug 4, 2020
The name is now required when creating or granting API keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grant API key should mandate key name as create API key action
4 participants