Correct type parametrization in geo mappers. #59583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the concrete type parameters for the MappedFieldType didn't always match those for the FieldMapper. This PR updates the mappers so that the type parameters always match, which makes the design easier to follow.
jtibshirani
added
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-search (:Search/Mapping) |
|
The context: I'm doing some minor clean-up in preparation supporting geo fields in the field retrieval API. |
talevy
approved these changes
Jul 15, 2020
jtibshirani
added a commit
that referenced
this pull request
Jul 15, 2020
Previously the concrete type parameters for the MappedFieldType didn't always match those for the FieldMapper. This PR updates the mappers so that the type parameters always match, which makes the design easier to follow.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 15, 2020
Eclipse was confused by elastic#59583. It can't see a the public inner interface within the superclass. This time. Usually that is fine, but the Eclipse gods don't like this particular code, I guess.
nik9000
added a commit
that referenced
this pull request
Jul 15, 2020
Eclipse was confused by #59583. It can't see a the public inner interface within the superclass. This time. Usually that is fine, but the Eclipse gods don't like this particular code, I guess.
nik9000
added a commit
that referenced
this pull request
Jul 16, 2020
Eclipse was confused by #59583. It can't see a the public inner interface within the superclass. This time. Usually that is fine, but the Eclipse gods don't like this particular code, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for geo mappers, the concrete type parameters for the
MappedFieldType didn't always match those for FieldMapper. This PR updates the
mappers so that the type parameters always match, which makes the design easier
to follow.