Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default write queue size #59464

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Conversation

Tim-Brooks
Copy link
Contributor

@Tim-Brooks Tim-Brooks commented Jul 13, 2020

This commit increases the default write queue size to 10000. This is to
allow a greater number of pending indexing requests. This work is safe
as we have added additional memory limits. Relates to #59263.

This commit increases the default write queue size to 4000. This is to
allow a greater number of pending indexing requests. This work is safe
as we have added additional memory limits.
@Tim-Brooks Tim-Brooks added >breaking :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v7.9.0 labels Jul 13, 2020
@Tim-Brooks Tim-Brooks requested a review from ywelsch July 13, 2020 20:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CRUD)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 13, 2020
@Tim-Brooks
Copy link
Contributor Author

After this is merged, it needs to be forward ported to 8.0 without the release notes. I have added a meta issue for that.

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the actual change to the setting.

docs/reference/release-notes/7.9.asciidoc Outdated Show resolved Hide resolved
@Tim-Brooks Tim-Brooks requested a review from ywelsch July 14, 2020 15:18
@Tim-Brooks Tim-Brooks requested a review from ywelsch July 14, 2020 15:46
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Brooks Tim-Brooks merged commit a46e5e0 into elastic:7.x Jul 14, 2020
@Tim-Brooks
Copy link
Contributor Author

This is currently labelled breaking as it changes a major default setting - the WRITE queue size from 200->10,000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants