-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexing pressure documentation #59456
Add indexing pressure documentation #59456
Conversation
This commit adds documentation about the new indexing pressure memory limit setting and exposure of this metrics in node stats.
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-distributed (:Distributed/CRUD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some initial comments.
TODO: When this is back ported to 7.9, the release doc comments should link to this new documentation page. |
I need to investigate why the linking is broken in one part. |
@jrodewig - Any tips about how to solve my linking issue? |
Specifically linking |
Actually I fixed the linking issue. This is ready for review @jrodewig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some non-blocking suggestions you can take or leave as you see fit.
`coordinating_and_primary_bytes`:: | ||
(integer) | ||
Bytes consumed by indexing requests in the coordinating or primary stage. | ||
|
||
`replica_bytes`:: | ||
(integer) | ||
Bytes consumed by indexing requests in the replica stage. | ||
|
||
`all_bytes`:: | ||
(integer) | ||
Bytes consumed by indexing requests in the coordinating, primary, or replica stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are human readable versions of these stats available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not. My understanding is that human readable versions is disabled by default. So I think we can add human readable interpretations in 7.10? @ywelsch I assume it is too late to make this change after feature freeze since it is kind of a feature?
|
||
`coordinating_and_primary_memory_limit_rejections`:: | ||
(integer) | ||
Rejections of indexing requests in the coordinating or primary stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejections of indexing requests in the coordinating or primary stage. | |
Number of indexing requests rejected in the coordinating or primary stage. |
(integer) | ||
Bytes consumed by indexing requests in the coordinating or primary stage. This | ||
value is not the sum of coordinating_bytes and primary_bytes as a node can reuse | ||
the coordinating bytes if the primary is executed locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the primary "stage" is executed locally
=== Indexing stages | ||
|
||
External indexing operations go through three stages: coordinating, primary, and | ||
replica. See <<basic-write-model,here>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this link need fixing? (<>)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the here
text:
replica. See <<basic-write-model,here>>. | |
replica. See <<basic-write-model>>. |
This commit adds documentation about the new indexing pressure memory limit setting and exposure of this metrics in node stats.
This commit adds documentation about the new indexing pressure memory limit setting and exposure of this metrics in node stats.
This commit adds documentation about the new indexing pressure memory
limit setting and exposure of this metrics in node stats.