Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default gateway.auto_import_dangling_indices to false #58898

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Default gateway.auto_import_dangling_indices to false #58898

merged 1 commit into from
Jul 9, 2020

Conversation

pugnascotia
Copy link
Contributor

Part of #48366. Now that there is a dedicated API for dangling indices,
the auto-import behaviour can default to off.

Docs will be updated in #58751.

@pugnascotia
Default gateway.auto_import_dangling_indices to false
7e650b1 
Part of elastic#48366. Now that there is a dedicated API for dangling indices,
the auto-import behaviour can default to off.
@pugnascotia pugnascotia added >enhancement >breaking :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v8.0.0 v7.9.0 labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Distributed)

@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Jul 2, 2020
@pugnascotia pugnascotia mentioned this pull request Jul 2, 2020
Merged
DaveCTurner
DaveCTurner reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, but I think this needs an entry in the breaking changes docs too.

DaveCTurner
DaveCTurner approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, the breaking changes docs for 7.9 don't exist in master so this LGTM for 8.0 and the docs can be added for the back port.

@pugnascotia
Copy link
Contributor Author

@DaveCTurner Thanks for the reminder about the breaking changes doc 👍

@pugnascotia pugnascotia merged commit 650f20e into elastic:master Jul 9, 2020
@pugnascotia pugnascotia deleted the auto-dangling-index-import-default-off branch July 9, 2020 12:57
@pugnascotia pugnascotia mentioned this pull request Jul 9, 2020
Merged
pugnascotia added a commit to pugnascotia/elasticsearch that referenced this pull request Jul 15, 2020
@pugnascotia
Default gateway.auto_import_dangling_indices to false (elastic#58898)
71e6b48 
Part of elastic#48366. Now that there is a dedicated API for dangling indices,
the auto-import behaviour can default to off.
pugnascotia added a commit that referenced this pull request Jul 15, 2020
@pugnascotia
Default gateway.auto_import_dangling_indices to false (#59302)
b8d73a1 
Backport of #58898.

Part of #48366. Now that there is a dedicated API for dangling indices, the auto-import
behaviour can default to off. Also add a note to the breaking changes for 7.9.0.
pugnascotia added a commit that referenced this pull request Jul 15, 2020
@pugnascotia
Default gateway.auto_import_dangling_indices to false (#59302)
84f4635 
Backport of #58898.

Part of #48366. Now that there is a dedicated API for dangling indices, the auto-import
behaviour can default to off. Also add a note to the breaking changes for 7.9.0.
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
>breaking :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >enhancement Team:Distributed Meta label for distributed team v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pugnascotia @elasticmachine @DaveCTurner @jakelandis