Fix wrong pipeline name in debug log #58817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
the
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
|
@elasticmachine update branch |
danhermann
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Thanks, @gaobinlong. This looks good and I'll get it merged in.
|
@danhermann, thanks for your review. |
|
@elasticmachine ok to test |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 17, 2020
This was referenced Aug 17, 2020
danhermann
added a commit
that referenced
this pull request
Aug 21, 2020
javanna
pushed a commit
that referenced
this pull request
Aug 24, 2020
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 26, 2020
danhermann
added a commit
that referenced
this pull request
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #58478.
When the ingest pipeline processes failed in bulk API, we can find a debug log which prints
failed to execute pipeline [_none] for document..., the pipeline name is always_none. That's becausepipelineinindexRequestis set to_nonewhen executing the ingest pipeline:elasticsearch/server/src/main/java/org/elasticsearch/ingest/IngestService.java
Line 366 in cc3bd39
The main point of this PR is moving the logging to IngestService#executePipelines(), so we can get the real pipeline name when printing the debug log.