Enforce higher priority for RepositoriesService ClusterStateApplier #58808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids shards allocation failures when the repository instance comes in the same ClusterState update as the shard allocation.
fcofdez
added
>enhancement
:Distributed Coordination/Cluster Coordination
ywelsch
reviewed
Jul 1, 2020
| import static org.hamcrest.Matchers.greaterThan; | ||
| import static org.hamcrest.Matchers.is; | ||
|
|
||
| @ESIntegTestCase.ClusterScope(scope = TEST, numDataNodes = 0, autoManageMasterNodes = false) |
There was a problem hiding this comment.
Why autoManageMasterNodes = false?
There was a problem hiding this comment.
That was the only scenario where I was able to reproduce the failure consistently. I was missing the gateway.recover_after_data_nodes piece
.../test/java/org/elasticsearch/xpack/searchablesnapshots/ClusterStateApplierOrderingTests.java
Outdated
Show resolved
Hide resolved
.../test/java/org/elasticsearch/xpack/searchablesnapshots/ClusterStateApplierOrderingTests.java
Show resolved
Hide resolved
| internalCluster().fullRestart(); | ||
|
|
||
| List<UnassignedInfo.Reason> unassignedReasons = new ArrayList<>(); | ||
| internalCluster().clusterService().addListener(event -> { |
There was a problem hiding this comment.
Isn't this racing against state recovery and the actual allocation taking place? We might be adding the listener too late. Perhaps we should delay state recovery (for example by setting gateway.recover_after_data_nodes to 3 on restart, and start up a third data node after the listener is registered (on the master)).
There was a problem hiding this comment.
I wasn't aware of that setting, I'll use that approach.
|
@ywelsch should we backport this to 7.9? |
|
yes |
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jul 5, 2020
This avoids shards allocation failures when the repository instance comes in the same ClusterState update as the shard allocation. Backport of elastic#58808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids shards allocation failures when the repository instance
comes in the same ClusterState update as the shard allocation.