Fix handling of terminate_after when size is 0 #58212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terminate_after
is ignored on search requests that don't return top hits (size
set to 0)and don't track the number of hits accurately (
track_total_hits
).We use early termination when the number of hits to track is reached during collection
but this breaks the hard termination of
terminate_after
if it happens before we reachedthe
terminate_after
value.This change ensures that we continue to check
terminate_after
even if the tracking of totalhits has reached the provided value.
Closes #57624