Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per processor description for verbose simulate #58207

Merged

Conversation

jakelandis
Copy link
Contributor

For ingest node processors a per processor description
was recently added. This commit displays that description
in the verbose output of the pipeline simulation.

related #57906

======

@talevy - On #57906 it was briefly discussed this not was necessary. Which I agree, not necessary...but it is a pretty trivial change and feels more complete to include it the verbose output (especially since the tag is already displayed).

cc @jloleysens

For ingest node processors a per processor description
was recently added. This commit displays that description
in the verbose output of the pipeline simulation.

related elastic#57906
@jakelandis jakelandis added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.9.0 labels Jun 16, 2020
@jakelandis jakelandis requested a review from talevy June 16, 2020 22:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 16, 2020
Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

Do we need at least a unit test for the version-guard serialization?

@jakelandis
Copy link
Contributor Author

Do we need at least a unit test for the version-guard serialization?

added a test here: https://github.com/elastic/elasticsearch/pull/58207/commits/3862f4c3926a851bcd0fea8747125fc3d96efc4f

@jakelandis
Copy link
Contributor Author

thanks @talevy !

@jakelandis jakelandis merged commit 2d28f71 into elastic:master Jul 21, 2020
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Jul 21, 2020
For ingest node processors a per processor description
was recently added. This commit displays that description
in the verbose output of the pipeline simulation.

related elastic#57906
jakelandis added a commit that referenced this pull request Jul 21, 2020
For ingest node processors a per processor description
was recently added. This commit displays that description
in the verbose output of the pipeline simulation.

related #57906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants