-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per processor description for verbose simulate #58207
Per processor description for verbose simulate #58207
Conversation
For ingest node processors a per processor description was recently added. This commit displays that description in the verbose output of the pipeline simulation. related elastic#57906
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
Do we need at least a unit test for the version-guard serialization?
added a test here: https://github.com/elastic/elasticsearch/pull/58207/commits/3862f4c3926a851bcd0fea8747125fc3d96efc4f |
thanks @talevy ! |
For ingest node processors a per processor description was recently added. This commit displays that description in the verbose output of the pipeline simulation. related elastic#57906
For ingest node processors a per processor description
was recently added. This commit displays that description
in the verbose output of the pipeline simulation.
related #57906
======
@talevy - On #57906 it was briefly discussed this not was necessary. Which I agree, not necessary...but it is a pretty trivial change and feels more complete to include it the verbose output (especially since the tag is already displayed).
cc @jloleysens