-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore matching data streams if include_data_streams is false #57900
Ignore matching data streams if include_data_streams is false #57900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -61,7 +61,6 @@ | |||
index: logs-foobarbaz | |||
|
|||
- do: | |||
catch: bad_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails when this yaml test is executed with security enabled.
logs-*
is expanded to logs-foobar
and then later this fails with a 404.
So in order to make this test execute constantly with and without security enabled, we should change
index: logs-*
to `index: logs-foobar. This should change the meaning of this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out. It seems unfortunate that behavior can differ when security is enabled even when it is not restricting access to any of the items in the test. E.g., close logs-*
succeeds without security but fails with security enabled even though the user has access to both the logs-foobar
data stream and logs-foobarbaz
index. I suppose that difference in behavior already exists with indices and aliases, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that subtle difference in behaviour also exists with indices and aliases.
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
@elasticmachine update branch |
merge conflict between base and head |
2ef0ab5
to
dcf507e
Compare
9997d33
to
c514974
Compare
@elasticmachine run elasticsearch-ci/2 |
Currently, any requests that match a data stream on APIs that are not enabled for data streams return an error that a data stream was matched. This PR changes the name resolution to simply ignore data streams for APIs that are not enabled for data streams.
Relates to #53100
Relates to #57712