Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A Closed Curly Bracket #57803

Merged
merged 1 commit into from
Jun 9, 2020
Merged

A Closed Curly Bracket #57803

merged 1 commit into from
Jun 9, 2020

Conversation

mhdehghan
Copy link
Contributor

In the snippet, a closed curly bracket is missed. It leads to raise an error when Elasticsearch tries to fire an action.

@mhdehghan
A Closed Curly Bracket
e60b00a 
In the snippet, a closed curly bracket is missed. It leads to raise an error when Elasticsearch tries to fire an action.
@cla-checker-service
Copy link

cla-checker-service bot commented Jun 8, 2020 •
edited
Loading

💚 CLA has been signed

cbuescher
cbuescher approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@cbuescher
Copy link
Member

@mhdehghan would you mind signing the CLA so we can merge this?

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher added the >docs General docs changes label Jun 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@cbuescher cbuescher self-assigned this Jun 9, 2020
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 9, 2020
@mhdehghan
Copy link
Contributor Author

mhdehghan commented Jun 9, 2020 •
edited
Loading

@mhdehghan would you mind signing the CLA so we can merge this?

I've signed the CLA.
Electronic Record and Signature Disclosure:
Accepted: 6/9/2020 6:55:57 AM

Github Username: mhdehghan

@cbuescher
Copy link
Member

@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

@cbuescher
Copy link
Member

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

head repository does not exist

@cbuescher
Copy link
Member

The failing CI failures are clearly unrelated to the docs issue and I cannot update the branch since the head repository seems to have been deleted.
I will merge this nevertheless since all other relevant tests passed.

@cbuescher cbuescher merged commit cf5f011 into elastic:master Jun 9, 2020
cbuescher pushed a commit that referenced this pull request Jun 9, 2020
@mhdehghan
[Docs] Fix missing closing bracket for watcher webhook.asciidoc (#57803)
2c6bd97
cbuescher pushed a commit that referenced this pull request Jun 9, 2020
@mhdehghan
[Docs] Fix missing closing bracket for watcher webhook.asciidoc (#57803)
ca5a99e
cbuescher pushed a commit that referenced this pull request Jun 9, 2020
@mhdehghan
[Docs] Fix missing closing bracket for watcher webhook.asciidoc (#57803)
fa0b82f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

@cbuescher cbuescher

Labels
>docs General docs changes Team:Docs Meta label for docs team v7.7.2 v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhdehghan @cbuescher @elasticmachine @jakelandis