Add description to submit and get async search, as well as cancel tasks #57745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to debug where such tasks come from in case they are returned from the get tasks API. Also renamed the last occurrence of waitForCompletion to waitForCompletionTimeout in get async search request.
javanna
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
approved these changes
Jun 5, 2020
| return "waitForCompletionTimeout[" + waitForCompletionTimeout + | ||
| "], keepOnCompletion[" + keepOnCompletion + | ||
| "] keepAlive[" + keepAlive + | ||
| "], request=" + request.getDescription(); |
There was a problem hiding this comment.
SubmitAsyncSearchRequest should also override getDescription ?
There was a problem hiding this comment.
ehm, actually, what I did is not needed for submit, because we already provide the description to createTask, which is the result of submit#toString, which holds the same info that I meant to add. So nothing to do for submit unless we want to generate the description in a lazy way like search does.
There was a problem hiding this comment.
let's do it lazily since we print the request too ?
|
run elasticsearch-ci/bwc |
javanna
added a commit
that referenced
this pull request
Jun 8, 2020
…ks (#57745) This makes it easier to debug where such tasks come from in case they are returned from the get tasks API. Also renamed the last occurrence of waitForCompletion to waitForCompletionTimeout in get async search request.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to debug where such tasks come from in case they are returned from the get tasks API.
Also renamed the last occurrence of waitForCompletion to waitForCompletionTimeout in get async search request.