[DOCS] Add safeguard directory attributes #57628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRs #57390 and #57489 swapped all instances of the `{docdir}` and `{asciidoc-dir}` attributes to `{es-repo-dir}`. Using `{es-repo-dir}` exclusively prevents issues when content from the ES refernce is reused in other doc books. This adds related safeguard attributes, which fall back to `{es-repo-dir}`. This should curb future problems if a contributor accidentally uses `{docdir}` or `{asciidoc-dir}`.
|
Pinging @elastic/es-docs (>docs) |
|
Turns out this won't help downstream books reusing the repo so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs #57390 and #57489 swapped all instances of the
{docdir}and{asciidoc-dir}attributes to{es-repo-dir}. Using{es-repo-dir}exclusively prevents issues when content from the ES refernce is reused
in other doc books.
This adds related safeguard attributes, which fall back to
{es-repo-dir}. Thisshould curb future problems if a contributor accidentally uses
{docdir}or{asciidoc-dir}.