Mute EmailSslTests test case in fips #57576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We test expected TLS failures by catching SSLException, but other security providers ( i.e. BCFIPS ) might throw a different one. In this case, BCFIPS throws org.bouncycastle.tls.TlsFatalAlert
|
Heh. Funny thing is this test was originally muted on FIPS, but for no good reason (it doesn't disable verification_mode or use a keystore), I didn't think about the exception. |
tvernum
approved these changes
Jun 3, 2020
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 3, 2020
We test expected TLS failures by catching SSLException, but other security providers ( i.e. BCFIPS ) might throw a different one. In this case, BCFIPS throws org.bouncycastle.tls.TlsFatalAlert
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 3, 2020
We test expected TLS failures by catching SSLException, but other security providers ( i.e. BCFIPS ) might throw a different one. In this case, BCFIPS throws org.bouncycastle.tls.TlsFatalAlert
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 3, 2020
We test expected TLS failures by catching SSLException, but other security providers ( i.e. BCFIPS ) might throw a different one. In this case, BCFIPS throws org.bouncycastle.tls.TlsFatalAlert
jkakavas
added a commit
that referenced
this pull request
Jun 3, 2020
jkakavas
added a commit
that referenced
this pull request
Jun 3, 2020
jkakavas
added a commit
that referenced
this pull request
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test expected TLS failures by catching SSLException, but other
security providers ( i.e. BCFIPS ) might throw a different one. In
this case, BCFIPS throws org.bouncycastle.tls.TlsFatalAlert
The test was introduced recently in #56090. We are tracking this
test issue already in #49094