Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Implement TRIM function #57518

Merged
merged 1 commit into from
Jun 3, 2020
Merged

SQL: Implement TRIM function #57518

merged 1 commit into from
Jun 3, 2020

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Jun 2, 2020

Add TRIM function which combines the functionality of both
LTRIM and RTRIM by stripping both leading and trailing
whitespaces.

Refers to #41195

@matriv matriv requested review from costin, astefan and bpintea June 2, 2020 12:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jun 2, 2020
@matriv
SQL: Implement TRIM function
2a6abf6 
Add `TRIM` function which combines the functionality of both
`LTRIM` and `RTRIM` by stripping both leading and trailinng
whitespaces.

Refers to elastic#41195
costin
costin approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bpintea
bpintea approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

astefan
astefan approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 6c86c91 into elastic:master Jun 3, 2020
@matriv matriv deleted the impl-trim branch June 3, 2020 12:24
matriv added a commit that referenced this pull request Jun 3, 2020
@matriv
SQL: Implement TRIM function (#57518) (#57593)
a674844 
Add `TRIM` function which combines the functionality of both
`LTRIM` and `RTRIM` by stripping both leading and trailing
whitespaces.

Refers to #41195

(cherry picked from commit 6c86c91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea approved these changes

@astefan astefan astefan approved these changes

@costin costin costin approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement Team:QL (Deprecated) Meta label for query languages team v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matriv @elasticmachine @costin @astefan @bpintea @jakelandis