Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edit validation section of dynamic templates docs #57510

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

liebeslied
Copy link
Contributor

@liebeslied liebeslied commented Jun 2, 2020

A few changes to try to make this documentation clearer.

honestly I'm still not sure I understand this paragraph, and therefore whether my rewording accurately rephrases it. Is it saying that any fields matching the template have to be indexed as string types unless using match_mapping_type? Clarifications welcome!

If no match_mapping_type has been specified then if the template is valid with one predefined mapping type then the mapping snippet is considered valid. However if at index time a field that matches with the template is indexed as a different type then an validation error will occur at index time instead. For example configuring a dynamic template with no match_mapping_type is considered valid as string type, but at index time a field that matches with the dynamic template is indexed as a long, then at index time a validation error may still occur.

@cbuescher cbuescher added the >docs General docs changes label Jun 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 2, 2020
@jrodewig jrodewig self-requested a review June 2, 2020 12:28
@jrodewig jrodewig added the :Search Foundations/Mapping Index mappings, including merging and defining field types label Jun 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 2, 2020
@jrodewig jrodewig added v7.7.2 v7.8.1 v7.9.0 v8.0.0 and removed Team:Search Meta label for search team labels Jun 2, 2020
@jrodewig jrodewig changed the title Edit validation section of dynamic templates docs [DOCS] Edit validation section of dynamic templates docs Jun 2, 2020
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @liebeslied.

I'm going to incorporate a few suggestions, but your improvements made this much more readable.

docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/dynamic/templates.asciidoc Outdated Show resolved Hide resolved
@jrodewig
Copy link
Contributor

jrodewig commented Jun 2, 2020

@elasticmachine test this please

@jrodewig
Copy link
Contributor

jrodewig commented Jun 2, 2020

@elasticmachine test this please

@jrodewig
Copy link
Contributor

jrodewig commented Jun 2, 2020

Backport commits

master 62e2778
7.x dc12a68
7.8 3f852e1
7.7 8c6ada2

@liebeslied
Copy link
Contributor Author

@jrodewig nice, thank you :)

@liebeslied liebeslied deleted the patch-2 branch June 3, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team v7.7.2 v7.8.1 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants