-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose discard_compound_token option to kuromoji_tokenizer #57421
Merged
jimczi
merged 2 commits into
elastic:master
from
johtani:expose-kuromoji-discard-compound-token-option
Jun 5, 2020
Merged
Expose discard_compound_token option to kuromoji_tokenizer #57421
jimczi
merged 2 commits into
elastic:master
from
johtani:expose-kuromoji-discard-compound-token-option
Jun 5, 2020
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in KuromojiTokenizerFactory Fix documentation bug in kuromoji_tokenizer extended mode
cbuescher
added
:Search Relevance/Analysis
How text is split into tokens
>enhancement
labels
Jun 2, 2020
Pinging @elastic/es-search (:Search/Analysis) |
@elasticmachine ok to test |
@elasticmachine update branch |
jimczi
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, It's nice to see you around here again @johtani ;)
@jimczi Thanks for reviewing my PR :D |
jimczi
pushed a commit
that referenced
this pull request
Jun 5, 2020
This commit exposes the new Lucene option `discard_compound_token` to the Elasticsearch Kuromoji plugin.
29 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jul 31, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#57421 Co-authored-by: Russ Cam <[email protected]>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#57421 Co-authored-by: Russ Cam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:Search Relevance/Analysis
How text is split into tokens
Team:Search
Meta label for search team
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Lucene 8.5, Japanese Tokenizer introduced new option
DiscardCmpoundToken
(LUCENE-9123)This PR exposes new option to Elasticsearch kuromoji plugin.
And I found 2 bug around Kuromoji Tokenizer.
discartPunctuation
) in KuromojiTokenizerFactoryextended
modeextended
mode output of関西国際空港
is same assearch
mode output.Please let me know, if I should split this PR to new feature and fix typo.
gradle check
? Yes, with-p plugins/analysis-kuromoji
option