Disable testingConventions in build tools in fips #57357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary since we also disable test and testingConventions would fail in FIPS 140 mode.
jkakavas
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
@elasticmachine update branch |
rjernst
approved these changes
May 29, 2020
|
Fair ! I should have done this when originally muting these, but will add now |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 2, 2020
* Disable testingConventions in build tools in fips Necessary since we also disable unit tests and testingConventions would fail in FIPS 140 mode.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 2, 2020
* Disable testingConventions in build tools in fips Necessary since we also disable unit tests and testingConventions would fail in FIPS 140 mode.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 2, 2020
* Disable testingConventions in build tools in fips Necessary since we also disable unit tests and testingConventions would fail in FIPS 140 mode.
jkakavas
added a commit
that referenced
this pull request
Jun 2, 2020
jkakavas
added a commit
that referenced
this pull request
Jun 2, 2020
jkakavas
added a commit
that referenced
this pull request
Jun 2, 2020
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary since we also disable test and testingConventions would
fail in FIPS 140 mode.