-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test error reporting to java plugin #57259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the global hook for reporting failed test cases to the ElasticsearchJavaPlugin. It should always be applied for all java projects since the Test class is what emits the failures logged.
rjernst
added
:Delivery/Build
Build or test infrastructure
>refactoring
v8.0.0
v7.8.1
v7.9.0
v7.7.2
labels
May 27, 2020
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
rjernst
added a commit
that referenced
this pull request
May 28, 2020
This commit moves the global hook for reporting failed test cases to the ElasticsearchJavaPlugin. It should always be applied for all java projects since the Test class is what emits the failures logged.
rjernst
added a commit
that referenced
this pull request
May 28, 2020
This commit moves the global hook for reporting failed test cases to the ElasticsearchJavaPlugin. It should always be applied for all java projects since the Test class is what emits the failures logged.
rjernst
added a commit
that referenced
this pull request
May 28, 2020
This commit moves the global hook for reporting failed test cases to the ElasticsearchJavaPlugin. It should always be applied for all java projects since the Test class is what emits the failures logged.
mark-vieira
added
Team:Delivery
Meta label for Delivery team
and removed
Team:Core/Infra
Meta label for core/infra team
labels
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Build
Build or test infrastructure
>refactoring
Team:Delivery
Meta label for Delivery team
v7.7.2
v7.8.1
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the global hook for reporting failed test cases to the
ElasticsearchJavaPlugin. It should always be applied for all java
projects since the Test class is what emits the failures logged.