Move gradle version check to global build info plugin #57255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gradle version check currently exists in BuildPlugin. However, there is no reason to check this within every project. Instead, this commit moves the check to the global build info, which is only applied to the root project. Additionally, this commit removes the check from buildSrc because it is not really necessary. The check exists really just for external plugin authors since we use the gradle wrapper for our own build.
rjernst
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
added a commit
that referenced
this pull request
May 28, 2020
The gradle version check currently exists in BuildPlugin. However, there is no reason to check this within every project. Instead, this commit moves the check to the global build info, which is only applied to the root project. Additionally, this commit removes the check from buildSrc because it is not really necessary. The check exists really just for external plugin authors since we use the gradle wrapper for our own build.
rjernst
added a commit
that referenced
this pull request
May 28, 2020
The gradle version check currently exists in BuildPlugin. However, there is no reason to check this within every project. Instead, this commit moves the check to the global build info, which is only applied to the root project. Additionally, this commit removes the check from buildSrc because it is not really necessary. The check exists really just for external plugin authors since we use the gradle wrapper for our own build.
rjernst
added a commit
that referenced
this pull request
May 28, 2020
The gradle version check currently exists in BuildPlugin. However, there is no reason to check this within every project. Instead, this commit moves the check to the global build info, which is only applied to the root project. Additionally, this commit removes the check from buildSrc because it is not really necessary. The check exists really just for external plugin authors since we use the gradle wrapper for our own build.
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradle version check currently exists in BuildPlugin. However, there
is no reason to check this within every project. Instead, this commit
moves the check to the global build info, which is only applied to the
root project. Additionally, this commit removes the check from buildSrc
because it is not really necessary. The check exists really just for
external plugin authors since we use the gradle wrapper for our own
build.