Fix up-to-date checks for precommit related tasks

[breskeby]

• Do not use lambdas for doFirst / doLast action declarations as this is not supported by gradle up-to-date check
• Use marker output folder for dependencies license task to make task incremental build compliant

[elasticmachine]

Pinging @elastic/es-core-infra (:Core/Infra/Build)

[pugnascotia]

The changes LGTM.

I was wondering whether it's worth defining a wrapper of some kind, so that we don't have to keep repeating the "Explicitly using an Action interface" comments. Something like:

jarTask.doFirst(TaskWrapper.of(task -> { ... }))

where the implementation is something like:

public class TaskWrapper {
    /**
     * Explicitly use an Action interface as Java lambdas
     * are not supported by Gradle up-to-date checks
     */
    public static Action<Task> of(Consumer<Task> fn) {
        return new Action<Task>() {
            @Override
            public void execute(Task task) {
                fn.call(task);
            }
        }
    }
}

[breskeby]

The changes LGTM.

I was wondering whether it's worth defining a wrapper of some kind, so that we don't have to keep repeating the "Explicitly using an Action interface" comments. Something like:

jarTask.doFirst(TaskWrapper.of(task -> { ... }))

where the implementation is something like:

public class TaskWrapper {
    /**
     * Explicitly use an Action interface as Java lambdas
     * are not supported by Gradle up-to-date checks
     */
    public static Action<Task> of(Consumer<Task> fn) {
        return new Action<Task>() {
            @Override
            public void execute(Task task) {
                fn.call(task);
            }
        }
    }
}

@pugnascotia Neat idea, but I checked and this wrapper could potentially break the up-to-date check when the implementation of the lambda changes. The problem is that a change in the implementationof a lambda cannot be tracked properly by gradle

[mark-vieira]

Changes LGTM 👍

[pugnascotia]

@breskeby Ah, that's shame. Never mind then. 👍