Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix remote cluster client node docs #57176

Merged
merged 2 commits into from
May 27, 2020
Merged

[DOCS] Fix remote cluster client node docs #57176

merged 2 commits into from
May 27, 2020

Conversation

nickcanz
Copy link
Contributor

@nickcanz nickcanz commented May 26, 2020 •
edited by jrodewig
Loading

This pull request updates the documentation for the new-ish remote_cluster_client node role.

  • Added this information to the _cat/nodes documentation
  • Fixed a typo of this attribute in another portion of the documentation

Relates to #54816

@jrodewig jrodewig self-requested a review May 26, 2020 21:24
@jrodewig jrodewig added :Core/Infra/Plugins Plugin API and infrastructure >docs General docs changes labels May 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 26, 2020
@jrodewig jrodewig self-assigned this May 26, 2020
@jrodewig jrodewig changed the title Add fix remote cluster client info to docs [DOCS] Fix remote cluster client node docs May 26, 2020
@jrodewig
Copy link
Contributor

@elasticmachine test this please

@jrodewig
Copy link
Contributor

LGTM. I'll merge this tomorrow assuming CI tests pass. Thanks @nickcanz!

@nickcanz
Copy link
Contributor Author

Sounds good @jrodewig! You're welcome!

@jrodewig jrodewig removed their assignment May 27, 2020
@jrodewig jrodewig merged commit 8d70f06 into elastic:master May 27, 2020
This was referenced May 27, 2020
Merged
Merged
jrodewig added a commit that referenced this pull request May 27, 2020
@jrodewig
[DOCS] Fix remote cluster client node docs (#57176) (#57205)
2c2673d 
Changes:

* Documents the `r` role in the _cat/nodes API docs

* Fixes a typo in the node docs

Co-authored-by: Nick Canzoneri <[email protected]>
jrodewig added a commit that referenced this pull request May 27, 2020
@jrodewig
[DOCS] Fix remote cluster client node docs (#57176) (#57206)
8546a0f 
Changes:

* Documents the `r` role in the _cat/nodes API docs

* Fixes a typo in the node docs

Co-authored-by: Nick Canzoneri <[email protected]>
@jrodewig
Copy link
Contributor

Backport commits

master 8d70f06
7.x 2c2673d
7.8 8546a0f

@nickcanz nickcanz deleted the add_fix_remote_cluster_client_info_to_docs branch December 21, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig Awaiting requested review from jrodewig

Assignees
No one assigned
Labels
:Core/Infra/Plugins Plugin API and infrastructure >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickcanz @elasticmachine @jrodewig