-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCS Repository YAML Test Build #57073
Merged
original-brownbear
merged 1 commit into
elastic:master
from
original-brownbear:investigate-gcs-test-failure
May 25, 2020
Merged
Fix GCS Repository YAML Test Build #57073
original-brownbear
merged 1 commit into
elastic:master
from
original-brownbear:investigate-gcs-test-failure
May 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes elastic#57026
original-brownbear
added
>test
Issues or PRs that are addressing/adding tests
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.9.0
labels
May 22, 2020
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
May 22, 2020
tlrx
approved these changes
May 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Armin
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 25, 2020
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes elastic#57026
original-brownbear
added a commit
that referenced
this pull request
May 25, 2020
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes #57026
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 27, 2020
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes elastic#57026
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 27, 2020
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes elastic#57026
original-brownbear
added a commit
that referenced
this pull request
May 27, 2020
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes #57026
original-brownbear
added a commit
that referenced
this pull request
May 27, 2020
A few relatively obvious issues here: * We cannot run the different IT runs (large blob setting one and normal integ run) concurrently * We need to set the dependency tasks up correctly for the large blob run so that it works in isolation * We can't use the `localAddress` for the location header of the resumable upload (this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host) Closes #57026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
>test
Issues or PRs that are addressing/adding tests
v7.7.1
v7.8.1
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few relatively obvious issues here:
localAddress
for the location header of the resumable upload(this breaks in YAML tests because GCS is using a loopback port forward for the initial request and the local address will be chosen as the actual Docker container host)
Closes #57026