-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add delete snapshot repo API docs #57043
Conversation
Adds API reference docs for the delete snapshot repo API. Also corrects an error in the delete snapshot repo API spec. Comma-separated repository names are not supported.
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other docs of this API are on the "take a snapshot" page for, I think, historical reasons. Could you move them to the "register a repository" page? Looks like just above the "shared file system repository" heading would be a good spot.
<titleabbrev>Delete snapshot repository</titleabbrev> | ||
++++ | ||
|
||
Deletes one or more <<snapshots-register-repository,snapshot repositories>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL we accept wildcards here :) But, trappily, not a comma-separated list.
Thanks @DaveCTurner. I've relocated the other delete repo docs to "Register a snapshot." I also updated some of the wording across the docs to better clarify that the delete snapshot API doesn't delete snapshots. |
@elasticmachine run elasticsearch-ci/bwc |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @jrodewig
Changes: * Adds API reference docs for the delete snapshot repo API. * Corrects an error in the delete snapshot repo API spec. Comma-separated repository names are not supported. * Relocates the existing delete snapshot repo API example docs.
Changes: * Adds API reference docs for the delete snapshot repo API. * Corrects an error in the delete snapshot repo API spec. Comma-separated repository names are not supported. * Relocates the existing delete snapshot repo API example docs.
Changes: * Adds API reference docs for the delete snapshot repo API. * Corrects an error in the delete snapshot repo API spec. Comma-separated repository names are not supported. * Relocates the existing delete snapshot repo API example docs.
Changes:
Adds API reference docs for the delete snapshot repo API.
Corrects an error in the delete snapshot repo API spec. Comma-separated repository names are not supported.
Relocates the existing delete snapshot repo API example docs.