Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7] Report used memory as zero when total memory cannot be obtained #56905

Merged

Conversation

danhermann
Copy link
Contributor

We're seeing test failures in 7.x on debian8 (though I have not been able to reproduce them) with negative values for used memory which we compute as total - free. We already coerce both total and free memory to zero if negative values are reported for either because @dakrone's work in #42725 demonstrated that negative values can be returned. That said, it does not appear that those occurrences necessarily coincide such that total may be reported as negative but free is reported as positive thus resulting in a potential free > total situation.

Backport of #56435

@danhermann danhermann added >bug :Data Management/Stats Statistics tracking and retrieval APIs backport v7.7.1 labels May 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Stats)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 18, 2020
@danhermann danhermann merged commit dd165f3 into elastic:7.7 May 18, 2020
@danhermann danhermann deleted the backport_56435_negative_mem_values branch May 18, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Data Management/Stats Statistics tracking and retrieval APIs Team:Data Management Meta label for data/management team v7.7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants