[DOCS] Fix default for http.compression setting
#56899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch enables HTTP compression by default now. However, to mitigate potential security risks like the BREACH attack, X-Pack security disables compression if HTTPS is enabled. <-- This is not clear from the doc, hence adding some more details here. See https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/SecurityHttpSettings.java#L19 and https://www.elastic.co/guide/en/x-pack/5.4/xpack-change-list.html#breaking-5.0.0 for more details.
Leaf-Lin
added a commit
to Leaf-Lin/logstash-output-elasticsearch
that referenced
this pull request
May 18, 2020
See elastic/elasticsearch#56899, Elasticsearch disables compression if HTTPS is enabled.
|
Pinging @elastic/es-docs (>docs) |
jrodewig
approved these changes
May 20, 2020
jrodewig
added
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
@tbrooks8 Do you mind taking a look at this when convenient? The logic in https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/SecurityHttpSettings.java#L19 seems clear to me, but it never hurts to double check. I can merge and backport if you approve. |
jrodewig
changed the title
http.compression setting
This was referenced May 20, 2020
jrodewig
added a commit
that referenced
this pull request
May 20, 2020
Elasticsearch enables HTTP compression by default. However, to mitigate potential security risks like the BREACH attack, compression is disabled by default if HTTPS is enabled. This updates the `http.compression` setting definition accordingly and adds additional context. Co-authored-by: Leaf-Lin <[email protected]>
jrodewig
added a commit
that referenced
this pull request
May 20, 2020
Elasticsearch enables HTTP compression by default. However, to mitigate potential security risks like the BREACH attack, compression is disabled by default if HTTPS is enabled. This updates the `http.compression` setting definition accordingly and adds additional context. Co-authored-by: Leaf-Lin <[email protected]>
jrodewig
added a commit
that referenced
this pull request
May 20, 2020
Elasticsearch enables HTTP compression by default. However, to mitigate potential security risks like the BREACH attack, compression is disabled by default if HTTPS is enabled. This updates the `http.compression` setting definition accordingly and adds additional context. Co-authored-by: Leaf-Lin <[email protected]>
karenzone
pushed a commit
to logstash-plugins/logstash-output-elasticsearch
that referenced
this pull request
Jul 30, 2020
See elastic/elasticsearch#56899, Elasticsearch disables compression if HTTPS is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch enables HTTP compression by default now. However, to mitigate potential security risks like the BREACH attack, X-Pack security disables compression if HTTPS is enabled. <-- This is not clear from the doc, hence adding some more details here.
See https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/SecurityHttpSettings.java#L19 and https://www.elastic.co/guide/en/x-pack/5.4/xpack-change-list.html#breaking-5.0.0 for more details.