Fix testDataOnlyNodePersistence #56893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failed if all 1000 top-level `rarely()` calls in the loop returned `false`, because then we would never set the term of the persisted state. This commit fixes this by adding an earlier call to `persistedState#setCurrentTerm` and also randomises the number of iterations to catch other potential issues like this. It also changes the test to clean up the threadpools it starts whether it passes or fails.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Review tip: if you ignore whitespace then this change is +11/−2 rather than +92/-83. |
DaveCTurner
added a commit
that referenced
this pull request
May 18, 2020
This test failed if all 1000 top-level `rarely()` calls in the loop returned `false`, because then we would never set the term of the persisted state. This commit fixes this by adding an earlier call to `persistedState#setCurrentTerm`. It also changes the test to clean up the threadpools it starts whether it passes or fails.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 18, 2020
PR elastic#56893 was supposed to randomise the iteration count in `testDataOnlyNodePersistence` but this change was mistakenly omitted. This commit addresses this.
DaveCTurner
added a commit
that referenced
this pull request
May 18, 2020
This test failed if all 1000 top-level `rarely()` calls in the loop returned `false`, because then we would never set the term of the persisted state. This commit fixes this by adding an earlier call to `persistedState#setCurrentTerm`. It also changes the test to clean up the threadpools it starts whether it passes or fails.
DaveCTurner
added a commit
that referenced
this pull request
May 18, 2020
PR #56893 was supposed to randomise the iteration count in `testDataOnlyNodePersistence` but this change was mistakenly omitted. This commit addresses this.
DaveCTurner
added a commit
that referenced
this pull request
May 18, 2020
PR #56893 was supposed to randomise the iteration count in `testDataOnlyNodePersistence` but this change was mistakenly omitted. This commit addresses this.
DaveCTurner
added a commit
that referenced
this pull request
May 18, 2020
PR #56893 was supposed to randomise the iteration count in `testDataOnlyNodePersistence` but this change was mistakenly omitted. This commit addresses this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed if all 1000 top-level
rarely()calls in the loop returnedfalse, because then we would never set the term of the persisted state. Thiscommit fixes this by adding an earlier call to
persistedState#setCurrentTermand also randomises the number of iterations to catch other potential issues
like this. It also changes the test to clean up the threadpools it starts
whether it passes or fails.
Closes #56763