Ensure dependency report task depends on upstream reporting tasks #56853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
added a commit
that referenced
this pull request
May 18, 2020
mark-vieira
added a commit
that referenced
this pull request
May 18, 2020
mark-vieira
added a commit
that referenced
this pull request
May 18, 2020
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the release manager generates the dependencies report, it does so as a single execution of
./gradlew dependenciesInfo :distribution:generateDependenciesReport. The issue with this is that the later task has no dependency, or ordering rule on the former. Couple that with parallel task execution and you run into an issue where we generate incomplete dependency reports.This PR fixes this issue by adding the correct task dependencies here. Now running
./gradlew generateDependenciesReportis sufficient enough to enough all individual project reports are created before concatenating them into the single master report.cc @mgreau
Closes https://github.com/elastic/infra/issues/20424