Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded component template YML test #56791

Merged

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented May 14, 2020

In 7.7 this test is unnecessary, as component templates were not used at all, and we now have tests
in the 7.8+ branches that test the functionality. The component template APIs were always behind a
system property flag and never actually exposed.

This test is causing failures where the system property flag was not set in all places where the
test was run, and rather than the added complexity of propogating the system property, it would be
better to remove the test from a branch where the functionality was never actually exposed.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
oli-obk Oli Scherer
In 7.7 this test is unnecessary, as component templates were not used at all, and we now have tests
in the 7.8+ branches that test the functionality. The component template APIs were always behind a
system property flag and never actually exposed.

This test is causing failures where the system property flag was not set in all places where the
test was run, and rather than the added complexity of propogating the system property, it would be
better to remove the test from a branch where the functionality was never actually exposed.
@dakrone dakrone added >non-issue :Data Management/Indices APIs APIs to create and manage indices and templates v7.7.1 labels May 14, 2020
@dakrone dakrone requested review from andreidan and probakowski May 14, 2020 20:34
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 14, 2020
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this Lee

@dakrone dakrone merged commit c18ddde into elastic:7.7 May 15, 2020
@dakrone dakrone deleted the itv2-remove-old-component-template-tests branch May 15, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >non-issue Team:Data Management Meta label for data/management team v7.7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants