[Transform] add support for terms agg in transforms #56696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
|
Reviewer, on the backport, I will place a check for |
benwtrent
force-pushed
the
feature/ml-add-terms-support-transforms
branch
from
1c8f47c
to
c18238c
Compare
hendrikmuhs
reviewed
May 14, 2020
| @@ -265,12 +265,12 @@ setup: | |||
| "group_by": { | |||
| "time": {"date_histogram": {"fixed_interval": "1h", "field": "time"}}}, | |||
| "aggs": { | |||
| "vals": {"terms": {"field":"airline"}} | |||
| "vals": {"significant_terms": {"field":"airline"}} | |||
| @@ -246,6 +250,35 @@ public Object value(Aggregation agg, Map<String, String> fieldTypeMap, String lo | |||
| } | |||
| } | |||
|
|
|||
| static class MultiBucketsAggExtractor implements AggValueExtractor { | |||
There was a problem hiding this comment.
👍 this is almost exactly the way I implemented it, too (well, there is probably no other way).
There was a problem hiding this comment.
Great minds think alike.
| if (bucket.getAggregations().iterator().hasNext() == false) { | ||
| nested.put(bucket.getKeyAsString(), bucket.getDocCount()); | ||
| } else { | ||
| HashMap<String, Object> nestedBucketObject = new HashMap<>(); |
There was a problem hiding this comment.
it would be good to cover this branch and have a test with nested terms aggs, like your common user example, broke down by e.g. businesses or filtered by something
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 15, 2020
This adds support for `terms` and `rare_terms` aggs in transforms. The default behavior is that the results are collapsed in the following manner: `<AGG_NAME>.<BUCKET_NAME>.<SUBAGGS...>...` Or if no sub aggs exist `<AGG_NAME>.<BUCKET_NAME>.<_doc_count>` The mapping is also defined as `flattened` by default. This is to avoid field explosion while still providing (limited) search and aggregation capabilities.
benwtrent
added a commit
that referenced
this pull request
May 15, 2020
…56809) * [Transform] add support for terms agg in transforms (#56696) This adds support for `terms` and `rare_terms` aggs in transforms. The default behavior is that the results are collapsed in the following manner: `<AGG_NAME>.<BUCKET_NAME>.<SUBAGGS...>...` Or if no sub aggs exist `<AGG_NAME>.<BUCKET_NAME>.<_doc_count>` The mapping is also defined as `flattened` by default. This is to avoid field explosion while still providing (limited) search and aggregation capabilities.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
termsandrare_termsaggs in transforms.The default behavior is that the results are collapsed in the following manner:
<AGG_NAME>.<BUCKET_NAME>.<SUBAGGS...>...Or if no sub aggs exist
<AGG_NAME>.<BUCKET_NAME>.<_doc_count>The mapping is also defined as
flattenedby default. This is to avoid field explosion while still providing (limited) search and aggregation capabilities.