Disable search context release checks after every test #56673
Conversation
This change adds a way to disable the checks that search contexts are all released after each test in ESTestCase. This is used by ESIntegTestCase to disable these checks if the cluster is shared across all methods (SUITE scope). In this case, the contexts are checked at the end when the cluster is cleared. This fixes integration tests that starts components that perform search requests internally with a fixed delay (e.g.: async search maintenance service). Fixes elastic#55988
jimczi
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
I meant in the async search tests that are failing due to this check. I wonder if there are other cases where the check may cause problems, and whether it is useful today in between tests, probably not. |
test/framework/src/main/java/org/elasticsearch/test/ESIntegTestCase.java
Outdated
Show resolved
Hide resolved
|
The initial fix doesn't work, we always check the releasing of search contexts before the node is stopped so the maintenance service continues to fire delete by query request. |
| @@ -71,6 +75,25 @@ public SearchTestPlugin() {} | |||
| } | |||
| } | |||
|
|
|||
| @Before | |||
| public void startMaitenanceService() { | |||
There was a problem hiding this comment.
s/Maitenance/Maintenance here and below
This change ensures that the maintenance service that is responsible for deleting the expired response is stopped between each test. This is needed since we check that no search context are in-flight after each test method. Fixes #55988
This change ensures that the maintenance service that is responsible for deleting the expired response is stopped between each test. This is needed since we check that no search context are in-flight after each test method. Fixes #55988
This change ensures that the maintenance service that is responsible for deleting the expired response is stopped between each test. This is needed since we check that no search context are in-flight after each test method. Fixes #55988
This change adds a way to disable the checks that search contexts are all released
after each test in ESTestCase.
This is used by ESIntegTestCase to disable these checks if the cluster is shared
across all methods (SUITE scope). In this case, the contexts are checked at the end
when the cluster is cleared. This fixes integration tests that starts components that
perform search requests internally with a fixed delay (e.g.: async search maintenance service).
Fixes #55988