-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use index sort range query when possible. #56657
Merged
jtibshirani
merged 5 commits into
elastic:master
from
jtibshirani:index-sort-range-query
May 13, 2020
Merged
Use index sort range query when possible. #56657
jtibshirani
merged 5 commits into
elastic:master
from
jtibshirani:index-sort-range-query
May 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>enhancement
:Search/Search
Search-related issues that do not fall into other categories
labels
May 13, 2020
Pinging @elastic/es-search (:Search/Search) |
jimczi
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jimczi for the review. |
This was referenced May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to use
IndexSortSortedNumericDocValuesRangeQuery
when possible to speed up certain range queries. Points-based queries are already very efficient, the only time this query makes a difference is when the range matches a large number of documents.Some notes:
date
,integer
, andlong
. I found that the query implementation isn't yet suited fordouble
orfloat
types (I will follow up with a Lucene issue).Below are benchmark results on the http-logs dataset. The following ranges were run against the
logs-241998
index:range-small (897633930, 897655999]: ~2M docs
range-medium (897623930, 897655999]: ~5M docs
range-large (897259801, 897503930]: ~21M docs
Relates to #48665.