Correct the type of the 'analyzer' parameter in the _analyze docs. #56650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optional parameter can only be a string. To test out a transient custom analysis chain, users are expected to use the 'tokenizer', 'filter', and 'char_filter' parameters.
jtibshirani
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Analysis) |
cbuescher
approved these changes
May 13, 2020
| You can also provide a <<analysis-custom-analyzer,custom analyzer>>. | ||
| (Optional, string) | ||
| The name of the analyzer that should be applied to the provided `text`. See <<analysis-analyzers>> | ||
| for a list of built-in analyzers. |
There was a problem hiding this comment.
Maybe we can mention that this also works for a custom analyzer that is defined in an index if "_analyze" is used on that index.
There was a problem hiding this comment.
I added a sentence to clarify that this can be any analyzer configured in the index, and not just a built-in analyzer.
|
Thanks for the review ! |
jtibshirani
added a commit
that referenced
this pull request
May 13, 2020
…56650) This optional parameter can only be a string. To test out a transient custom analysis chain, users are expected to use the 'tokenizer', 'filter', and 'char_filter' parameters.
jtibshirani
added a commit
that referenced
this pull request
May 13, 2020
…56650) This optional parameter can only be a string. To test out a transient custom analysis chain, users are expected to use the 'tokenizer', 'filter', and 'char_filter' parameters.
jtibshirani
added a commit
that referenced
this pull request
May 13, 2020
…56650) This optional parameter can only be a string. To test out a transient custom analysis chain, users are expected to use the 'tokenizer', 'filter', and 'char_filter' parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optional parameter can only be a string. To test out a transient custom
analysis chain, users are expected to use the 'tokenizer', 'filter', and
'char_filter' parameters.
Relates to #56586.