Remove ability to ingore files from spec validation #56647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
cc: @elastic/es-clients |
mark-vieira
approved these changes
May 12, 2020
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
May 13, 2020
An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask to allow the build to pass for REST specs that did not properly validate against the schema. Since the introduction of this task, all schemas that did not validate have been fixed to now validate properly. This commit removes the ability to ignore specific files for validation. This allows any consumers the assurance that all REST specs validate against the schema.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
May 13, 2020
An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask to allow the build to pass for REST specs that did not properly validate against the schema. Since the introduction of this task, all schemas that did not validate have been fixed to now validate properly. This commit removes the ability to ignore specific files for validation. This allows any consumers the assurance that all REST specs validate against the schema.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
May 13, 2020
An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask to allow the build to pass for REST specs that did not properly validate against the schema. Since the introduction of this task, all schemas that did not validate have been fixed to now validate properly. This commit removes the ability to ignore specific files for validation. This allows any consumers the assurance that all REST specs validate against the schema.
|
Thanks @jakelandis 👍 |
|
@jakelandis Can we remove the |
|
@mark-vieira - not yet. The backport PRs failed to pass. I have a 7.x only PR that will fix them, but it is still under for review : #56736 |
jakelandis
added a commit
that referenced
this pull request
May 27, 2020
…56691) An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask to allow the build to pass for REST specs that did not properly validate against the schema. Since the introduction of this task, all schemas that did not validate have been fixed to now validate properly. This commit removes the ability to ignore specific files for validation. This allows any consumers the assurance that all REST specs validate against the schema.
jakelandis
added a commit
that referenced
this pull request
May 27, 2020
…56690) An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask to allow the build to pass for REST specs that did not properly validate against the schema. Since the introduction of this task, all schemas that did not validate have been fixed to now validate properly. This commit removes the ability to ignore specific files for validation. This allows any consumers the assurance that all REST specs validate against the schema.
jakelandis
added a commit
that referenced
this pull request
May 27, 2020
…56689) An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask to allow the build to pass for REST specs that did not properly validate against the schema. Since the introduction of this task, all schemas that did not validate have been fixed to now validate properly. This commit removes the ability to ignore specific files for validation. This allows any consumers the assurance that all REST specs validate against the schema.
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ignore parameter was originally added to the ValidateJsonAgainstSchemaTask
to allow the build to pass for REST specs that did not properly validate
against the schema.
Since the introduction of this task, all schemas that did not validate have
been fixed to now validate properly.
This commit removes the ability to ignore specific files for validation. This
allows any consumers the assurance that all REST specs validate against the schema.