Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated shard limit doc #56496

Merged
merged 2 commits into from
Aug 24, 2020
Merged

updated shard limit doc #56496

merged 2 commits into from
Aug 24, 2020

Conversation

gadekishore
Copy link
Contributor

As the documentation was not so clear. I have updated saying total shard limit per node includes open indices with unassigned primaries and replicas count towards the limit.

As the documentation was not so clear. I have updated saying this limit includes open indices with unassigned primaries and replicas count towards the limit.
@gadekishore gadekishore added >docs General docs changes :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Docs Meta label for docs team labels May 11, 2020
@gadekishore gadekishore requested a review from debadair May 11, 2020 05:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Allocation)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 11, 2020
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Suggested an edit to condense the info about what does/doesn't count toward the limit.

Comment on lines 53 to 54
The limit defaults to 1,000 shards per data node, this includes open indices with unassigned primary or replica shards, and can be dynamically
adjusted using the following property:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd combine the info about what counts toward the limit with the info in the previous paragraph. Maybe:

The cluster shard limit defaults to 1,000 shards per data node. Both primary and replica shards of all open indices count toward the limit, including unassigned shards. For example, an open index with 5 primary shards and 2 replicas counts as 15 shards. Closed indices do not contribute to the shard count. You can dynamically adjust the limit with the following property:

@javanna javanna requested a review from gwbrown May 13, 2020 07:52
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ to updating the content here, with the notes @debadair added.

To add some context, unassigned shards are counted here because this a limit to prevent nodes from becoming unstable due to oversharding. If unassigned shards were not counted, we would likely see those counts spike as soon as the shards become assigned, which would rapidly increase memory usage on the node, possibly causing instability.

@colings86
Copy link
Contributor

@gadekishore @debadair Is this still relevant?

@debadair debadair merged commit fc50e17 into master Aug 24, 2020
@debadair debadair deleted the gadekishore-update-shard-limit-doc branch August 24, 2020 23:41
debadair added a commit to debadair/elasticsearch that referenced this pull request Aug 24, 2020
* updated shard limit doc

As the documentation was not so clear. I have updated saying this limit includes open indices with unassigned primaries and replicas count towards the limit.

* [DOCS] Incorporated edits.

Co-authored-by: Deb Adair <[email protected]>
debadair added a commit to debadair/elasticsearch that referenced this pull request Aug 24, 2020
* updated shard limit doc

As the documentation was not so clear. I have updated saying this limit includes open indices with unassigned primaries and replicas count towards the limit.

* [DOCS] Incorporated edits.

Co-authored-by: Deb Adair <[email protected]>
debadair added a commit that referenced this pull request Aug 25, 2020
* updated shard limit doc

As the documentation was not so clear. I have updated saying this limit includes open indices with unassigned primaries and replicas count towards the limit.

* [DOCS] Incorporated edits.

Co-authored-by: Deb Adair <[email protected]>

Co-authored-by: gadekishore <[email protected]>
debadair added a commit that referenced this pull request Aug 25, 2020
* updated shard limit doc

As the documentation was not so clear. I have updated saying this limit includes open indices with unassigned primaries and replicas count towards the limit.

* [DOCS] Incorporated edits.

Co-authored-by: Deb Adair <[email protected]>

Co-authored-by: gadekishore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants