-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce search context - point in time view of indices #56480
Conversation
With this change, we partially move the state of SearchContext to ReaderContext. This is another step allowing us to move the state of search to the coordinating node. We will need several follow-ups to move the entire search state to the coordinating node. Relates #46523
This reverts commit 3ce9a3b.
With this change, we partially move the state of SearchContext to ReaderContext. This is another step allowing us to move the state of search to the coordinating node. We will need several follow-ups to move the entire search state to the coordinating node. Relates #46523
This commit moves the states of search to the coordinating node instead of keeping them in the data node. Relates #46523
@mayya-sharipova I think we have addressed your comments. Would you please take another look? |
server/src/main/java/org/elasticsearch/action/search/SearchContextId.java
Outdated
Show resolved
Hide resolved
@dnhatn @jimczi Thanks for addressing my comments. I was trying to test recent changes with alias filters, and I am getting the following error:
I think that error happens because |
Thanks Mayya. 4a38f0d should address the issue. |
@dnhatn Thanks for the latest changes, open context search on alias filter and multiple indexes works well for me! I have also checked the latest code changes, and everything LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is very large so I focused on the high level and it makes sense to me. I wonder what is the motivation for marking it beta, this looks straightforward enough to me to not feel the need to mark it beta?
Another thing is that the docs make it obvious that it works with |
Jim and I discussed this PR offline. We decided to take a different approach. Thanks, everyone! |
Open a new search context:
Execute a search with a specific search context
Close a search context when it's no longer needed
Notable works in this change:
Relates #46523
Relates #26472
Co-authored-by: Jim Ferenczi [email protected]