Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bwcVersions extension property to BuildParams (back port) #56381

Merged
merged 2 commits into from
May 11, 2020
Merged

Move bwcVersions extension property to BuildParams (back port) #56381

merged 2 commits into from
May 11, 2020

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented May 7, 2020

breskeby and others added 2 commits May 7, 2020 21:03
@breskeby
Move bwcVersions extension property to BuildParams (elastic#56206)
bcecf68 
- resolved in GlobalBuildInfoPlugin
- propagate exception if version file cannot be resolved
- add null check when setting bwcVersions
@original-brownbear @breskeby
Fix :qa Task Using Broken BwC Versions Resolution (elastic#56332)
ee71a77 
I think we missed this spot in elastic#56206 breaking the task and thus Gradle imports into Idea.
@breskeby breskeby self-assigned this May 7, 2020
@breskeby breskeby mentioned this pull request May 7, 2020
Merged
@breskeby breskeby added the :Delivery/Build Build or test infrastructure label May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 7, 2020
@breskeby breskeby merged commit c29bc87 into elastic:7.x May 11, 2020
@breskeby breskeby deleted the fix/build/move-bwcVersions-to-build-params-7-x branch May 11, 2020 07:39
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@breskeby breskeby

Labels
backport :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breskeby @elasticmachine @mark-vieira @original-brownbear