[DOCS] Add collapsible sections to 8.0 breaking changes [Part 4] #56356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-docs (>docs) |
jrodewig
commented
May 7, 2020
Comment on lines
28
to
31
| *Impact* + | ||
| Use the available constants (e.g. Fuzziness.ONE, Fuzziness.AUTO) or build your | ||
| own instance using the above mentioned factory methods. Use only allowed | ||
| `Fuzziness` values. |
There was a problem hiding this comment.
@cbuescher Do you mind confirming that this accurately reflects your original guidance?
This is mostly a formatting change. I just want to ensure I don't unintentionally remove any context here.
Feel free to ignore the other changes in this PR unless you'd like to review them.
jrodewig
commented
May 7, 2020
25 tasks
debadair
suggested changes
May 7, 2020
Co-authored-by: debadair <[email protected]>
|
To go ahead and get the collapsible sections in, I've reverted most of the changes to the Java API changes section. I'll open a separate PR to get the impact sections of those changes approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds collapsible sections to the 8.0 breaking changes.
To make reviews easier and avoid introducing errors, I've
tried to limit my changes to formatting, with the exception
of rewording heading as sentences.
I'm also splitting this effort over several PRs to make reviews
manageable.
Relates to #55629 and #53229
Preview
http://elasticsearch_56356.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html