Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reader context to search context #56351

Merged
merged 2 commits into from
May 8, 2020
Merged

Rename reader context to search context #56351

merged 2 commits into from
May 8, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented May 7, 2020 •
edited
Loading

This change renames reader context to search context in the rest layer.

@dnhatn dnhatn added the WIP label May 7, 2020
@dnhatn dnhatn added :Search/Search Search-related issues that do not fall into other categories and removed WIP labels May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label May 7, 2020
@dnhatn dnhatn added the >feature label May 7, 2020
@dnhatn dnhatn marked this pull request as ready for review May 7, 2020 14:09
@dnhatn dnhatn requested a review from jimczi May 7, 2020 14:09
jimczi
jimczi approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented May 8, 2020

Thanks Jim

@dnhatn dnhatn merged commit c6dac42 into elastic:reader-context May 8, 2020
@dnhatn dnhatn deleted the rename-search-context branch May 8, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>feature :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnhatn @elasticmachine @jimczi