Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Extract the cron docs from Watcher docs and add to the API conventions. #56313

Merged
merged 5 commits into from
May 12, 2020
Merged

[DOCS] Extract the cron docs from Watcher docs and add to the API conventions. #56313

merged 5 commits into from
May 12, 2020

Conversation

debadair
Copy link
Contributor

@debadair debadair commented May 6, 2020

Picks up the changes from #49156, splits the cron expressions to a separate page, and adds the topic to the API conventions.

Based on the commits from #55953, will remove the WIP label once they've been merged.

@debadair debadair added >docs General docs changes WIP :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.7.0 v7.6.3 v7.8.0 labels May 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@cla-checker-service
Copy link

cla-checker-service bot commented May 6, 2020 •
edited
Loading

💚 CLA has been signed

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 6, 2020
@debadair debadair mentioned this pull request May 6, 2020
Closed
11 tasks
@debadair debadair force-pushed the cron_docs branch 2 times, most recently from 33e4bd2 to 37117bf Compare May 8, 2020 22:20
@jrodewig jrodewig mentioned this pull request May 11, 2020
Closed
@debadair debadair removed the WIP label May 11, 2020
@debadair debadair requested a review from jrodewig May 11, 2020 21:45
jrodewig
jrodewig approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part.

I believe we use a.m. and p.m. per the Elastic style guide. I left some other nits but
nothing I would consider blocking.

Thanks for taking care of this.

docs/reference/commands/croneval.asciidoc Outdated Show resolved Hide resolved
docs/reference/rest-api/cron-expressions.asciidoc Outdated Show resolved Hide resolved
docs/reference/rest-api/cron-expressions.asciidoc Show resolved Hide resolved
docs/reference/rest-api/cron-expressions.asciidoc Outdated Show resolved Hide resolved
docs/reference/rest-api/cron-expressions.asciidoc Outdated Show resolved Hide resolved
docs/reference/slm/getting-started-slm.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/watcher/trigger/schedule/cron.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/watcher/trigger/schedule/cron.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/watcher/trigger/schedule/cron.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/watcher/trigger/schedule/cron.asciidoc Outdated Show resolved Hide resolved
@debadair debadair merged commit 1412e80 into elastic:master May 12, 2020
debadair added a commit to debadair/elasticsearch that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Extract the cron docs from Watcher docs and add to the API con…
0c25c1a 
…ventions. (elastic#56313)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>
debadair added a commit to debadair/elasticsearch that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Extract the cron docs from Watcher docs and add to the API con…
ecfed3e 
…ventions. (elastic#56313)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>
debadair added a commit to debadair/elasticsearch that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Extract the cron docs from Watcher docs and add to the API con…
4dc9d89 
…ventions. (elastic#56313)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>
debadair added a commit to debadair/elasticsearch that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Extract the cron docs from Watcher docs and add to the API con…
66a508d 
…ventions. (elastic#56313)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>
This was referenced May 12, 2020
Merged
Merged
debadair added a commit that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Clarify definition of max_size (#56561) (#56648)
ed31d0d 
* [DOCS] Extract the cron docs from Watcher docs and add to the API conventions. (#56313)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>

* [DOCS] Clarify definition of max_size (#56561)

Co-authored-by: James Rodewig <[email protected]>
debadair added a commit that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Clarify definition of max_size (#56561) (#56649)
ec3d9b6 
* [DOCS] Extract the cron docs from Watcher docs and add to the API conventions. (#56313)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>

* [DOCS] Clarify definition of max_size (#56561)

Co-authored-by: James Rodewig <[email protected]>
debadair added a commit that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Extract the cron docs from Watcher docs and add to the API con…
425cc7e 
…ventions. (#56313) (#56652)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
debadair added a commit that referenced this pull request May 12, 2020
@debadair @jrodewig
[DOCS] Extract the cron docs from Watcher docs and add to the API con…
6de6ec6 
…ventions. (#56313) (#56651)

* [DOCS] Promote cron expressions info from Watcher to a separate topic.

* Fix table error

* Fixed xref

* Apply suggestions from code review

Co-authored-by: James Rodewig <[email protected]>

* Incorporated review feedback

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.6.3 v7.7.0 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debadair @elasticmachine @jrodewig @jakelandis