Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7] [ML] reduce InferenceProcessor.Factory log spam by not parsing pipelines (#56020) #56127

Merged
merged 3 commits into from
May 13, 2020

Conversation

benwtrent
Copy link
Member

Backports the following commits to 7.7:

…nes (elastic#56020)

If there are ill-formed pipelines, or other pipelines are not ready to be parsed, `InferenceProcessor.Factory::accept(ClusterState)` logs warnings. This can be confusing and cause log spam.

It might lead folks to think there an issue with the inference processor. Also, they would see logs for the inference processor even though they might not be using the inference processor. Leading to more confusion.

Additionally, pipelines might not be parseable in this method as some processors require the new cluster state metadata before construction (e.g. `enrich` requires cluster metadata to be set before creating the processor).

closes elastic#55985
@benwtrent benwtrent added :ml Machine learning backport labels May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent benwtrent merged commit b911f53 into elastic:7.7 May 13, 2020
@benwtrent benwtrent deleted the backport/7.7/pr-56020 branch October 19, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :ml Machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants