Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Bulk Snapshot Deletes to Abort (#56009) #56111

Merged
merged 1 commit into from
May 4, 2020

Conversation

original-brownbear
Copy link
Member

Making use of #55773 to simplify snapshot state machine.

  1. Deletes with no in-progress snapshot now add the delete entry to the cluster state right away
    instead of doing a second CS update after the fist update was a NOOP.
  2. If a bulk delete matches in-progress as well as completed snapshots, abort the in-progress snapshot
    and then move on to delete from the repository.

backport of #56009

Making use of elastic#55773 to simplify snapshot state machine.
1. Deletes with no in-progress snapshot now add the delete entry to the cluster state right away
instead of doing a second CS update after the fist update was a NOOP.
2. If a bulk delete matches in-progress as well as completed snapshots, abort the in-progress snapshot
and then move on to delete from the repository.
@original-brownbear original-brownbear added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs backport labels May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 4, 2020
@original-brownbear original-brownbear merged commit e8ef44c into elastic:7.x May 4, 2020
@original-brownbear original-brownbear deleted the 56009-7.x branch May 4, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants