Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPEin Netty4Transport.stopInternal #56080

Merged
merged 2 commits into from
May 4, 2020

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented May 2, 2020

Somewhat trivial but why not ...
Closes #56068

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Network)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 2, 2020
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/2

@original-brownbear
Copy link
Member Author

@elasticmachine update branch

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Tim!

@original-brownbear original-brownbear merged commit b3f4835 into elastic:master May 4, 2020
@original-brownbear original-brownbear deleted the 56068 branch May 4, 2020 16:39
@jrodewig
Copy link
Contributor

jrodewig commented May 4, 2020

@original-brownbear Do you mind checking the linked issue? I believe the wrong one is listed.

Just wanted to make sure it's right for release notes, etc. Thanks!

@original-brownbear
Copy link
Member Author

@jrodewig argh so sorry, off by one error in the issue number :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE from Netty4Transport#stopInternal if eventLoopGroup == null
5 participants