Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable can match for search with reader contexts #56032

Merged
merged 4 commits into from
May 4, 2020
Merged

Enable can match for search with reader contexts #56032

merged 4 commits into from
May 4, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 30, 2020

Enabling the can-match phase for search requests with reader contexts

@dnhatn dnhatn added >feature :Search/Search Search-related issues that do not fall into other categories labels Apr 30, 2020
@dnhatn dnhatn requested a review from jimczi April 30, 2020 13:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Apr 30, 2020
@dnhatn dnhatn changed the title Enable can match for search requests with reader contexts Enable can match for search with reader contexts Apr 30, 2020
jimczi
jimczi reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I left one comment.

server/src/main/java/org/elasticsearch/search/SearchService.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/search/SearchService.java Outdated Show resolved Hide resolved
@dnhatn
Copy link
Member Author

dnhatn commented May 1, 2020

@jimczi I pushed changes. Can you take another look? Thank you!

@dnhatn dnhatn requested a review from jimczi May 1, 2020 18:11
jimczi
jimczi approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented May 4, 2020

Thanks Jim!

@dnhatn dnhatn merged commit 3be26ed into elastic:reader-context May 4, 2020
@dnhatn dnhatn deleted the can-match-keep-alive branch May 4, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>feature :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnhatn @elasticmachine @jimczi