Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed peer recovery due to transient errors (#55353) #55883

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

Tim-Brooks
Copy link
Contributor

Currently a failed peer recovery action will fail an recovery. This
includes when the recovery fails due to potentially short lived
transient issues such as rejected exceptions or circuit breaking
errors.

This commit adds the concept of a retryable action. A retryable action
will be retryed in face of certain errors. The action will be retried
after an exponentially increasing backoff period. After defined time,
the action will timeout.

This commit only implements retries for responses that indicate the
target node has NOT executed the action.

Currently a failed peer recovery action will fail an recovery. This
includes when the recovery fails due to potentially short lived
transient issues such as rejected exceptions or circuit breaking
errors.

This commit adds the concept of a retryable action. A retryable action
will be retryed in face of certain errors. The action will be retried
after an exponentially increasing backoff period. After defined time,
the action will timeout.

This commit only implements retries for responses that indicate the
target node has NOT executed the action.
@Tim-Brooks Tim-Brooks added >non-issue :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. backport v7.8.0 labels Apr 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

@Tim-Brooks Tim-Brooks merged commit cd22809 into elastic:7.x Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >non-issue v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants