Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore closed exception on refresh pending location listener #55799

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Apr 27, 2020

This newly added listener should catch closed exceptions when
accessing the internal engine.

Closes #55792
Closes #55796
Relates #55428

This newly added listener should catch closed exceptions when
accessing the internal engine.

Closes elastic#55792
@jimczi jimczi added >test-failure Triaged test failures from CI :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.8.0 labels Apr 27, 2020
@jimczi jimczi requested a review from dnhatn April 27, 2020 12:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Jim for fixing this.

@jimczi jimczi merged commit db288a2 into elastic:master Apr 27, 2020
@jimczi jimczi deleted the index_shard_refresh_closed branch April 27, 2020 13:05
jimczi added a commit that referenced this pull request Apr 27, 2020
This newly added listener should catch closed exceptions when
accessing the internal engine.

Closes #55792
@jimczi jimczi added the v7.7.1 label May 26, 2020
jimczi added a commit to jimczi/elasticsearch that referenced this pull request May 26, 2020
…#55799)

This newly added listener should catch closed exceptions when
accessing the internal engine.

Closes elastic#55792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test-failure Triaged test failures from CI v7.7.1 v7.8.0 v8.0.0-alpha1
Projects
None yet
4 participants