Don't expand default_field in query_string before required (#55158) #55661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5158) Currently QueryStringQueryParser already checks if the field limit is breached at construction time, which e.g. leads to errors if the default field is set to "*" or the default isn't used and there are more fields than the limit, even if the query itself does not use all these fields. This change moves this check to happen after query parsing. QueryStringQueryParser now keeps track of the fields that are actually resolved while parsing. The size of that set is later used to check against the limit set by the `indices.query.bool.max_clause_count` setting. Closes elastic#53789
cbuescher
force-pushed
the
backport-55158-7-7
branch
from
86ce04c to
759305c
Compare
jpountz
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently QueryStringQueryParser already checks if the field limit is breached
at construction time, which e.g. leads to errors if the default field is set to
"*" or the default isn't used and there are more fields than the limit, even if the
query itself does not use all these fields.
This change moves this check to happen after query parsing. QueryStringQueryParser now
keeps track of the fields that are actually resolved while parsing. The size of
that set is later used to check against the limit set by the
indices.query.bool.max_clause_countsetting.Closes #53789